[Snippets] Fix text-to-image fetch snippets #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanouticelina
requested review from
julien-c,
SBrandeis and
coyotte508
as code owners
Wauplin
reviewed
Mar 28, 2025
packages/inference/src/snippets/templates/js/fetch/textToImage.jinja
Outdated
Show resolved
Hide resolved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with @Wauplin, we realized that some
text-to-imagejs snippets were incorrect, the key use to pass the prompt is different from a provider to another, so it's better to get the inputs from the body instead.EDIT: this PR does not fix totally the issue, since the input keys are customized per provider in the
textToImagefunction. This is fixed in #1315.EDIT 2: in a later PR we will apply a linter on the generated snippets which should make the snippets much nicer!